Skip to content

Run CLI tests on all warehouses instead of just Postgres#2094

Merged
haritamar merged 3 commits intomasterfrom
devin/1769520980-cli-tests-all-warehouses
Jan 27, 2026
Merged

Run CLI tests on all warehouses instead of just Postgres#2094
haritamar merged 3 commits intomasterfrom
devin/1769520980-cli-tests-all-warehouses

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot commented Jan 27, 2026 •
edited by coderabbitai Bot
Loading

Summary

This PR updates the CI workflow to run Elementary CLI tests on all warehouse platforms (postgres, snowflake, bigquery, redshift, databricks_catalog, athena) for pull requests, instead of only running on Postgres. This aligns the CLI repo's testing approach with the dbt-data-reliability package repo.

Key changes:

  • Added pull_request_target trigger to test-all-warehouses.yml (with same paths filter as before)
  • Removed dbt 1.8.0 from the test matrix, now only tests against latest dbt version
  • Skip Slack failure notifications for PR events to avoid spam
  • Deleted test-main-warehouse.yml (superseded by the updated workflow)

Resolves ELE-5218

Review & Testing Checklist for Human

  • Verify the pull_request_target + elementary-ref pattern correctly checks out the PR code (uses PR head SHA when triggered by pull_request_target)
  • Confirm removing dbt 1.8.0 from the matrix is acceptable - PRs will only test against latest dbt
  • Consider the increased CI time/cost: PRs will now run 6 warehouse tests instead of 1

Recommended test plan: Create a test PR that touches a file in elementary/ and verify that all 6 warehouse jobs are triggered and the elementary-ref correctly points to the PR branch code.

Notes

Summary by CodeRabbit

  • Chores
    • Updated CI/CD testing workflows for improved test automation and coverage across multiple warehouse types.

✏️ Tip: You can customize this high-level summary in your review settings.

@devin-ai-integration @haritamar
Run CLI tests on all warehouses instead of just Postgres
3b74f13 
- Add pull_request_target trigger to test-all-warehouses.yml
- Add workflow_call trigger for reusability
- Remove dbt 1.8.0 from matrix, run only on latest version
- Update elementary-ref to use PR head SHA for pull_request_target events
- Skip Slack notifications for PR failures to avoid spam
- Delete test-main-warehouse.yml (superseded by test-all-warehouses.yml)

Resolves ELE-5218

Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
@linear
Copy link
Copy Markdown

linear Bot commented Jan 27, 2026

ELE-5218 Elementary CLI tests should run on all warehouses like package

@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

devin-ai-integration Bot commented Jan 27, 2026

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 27, 2026

👋 @devin-ai-integration[bot]
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 27, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Consolidated CI/CD testing by adding pull_request_target trigger to the all-warehouses workflow, enabling tests across all warehouse types on pull requests. Removed the single-warehouse-only test workflow and reduced dbt version matrix to latest only.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Consolidation
.github/workflows/test-all-warehouses.yml		 Added pull_request_target trigger with master branch and path filters (elementary/\\, .github/\\, pyproject.toml). Changed dbt-version matrix default from ["1.8.0", null] to [null] to test only latest version. Enhanced elementary-ref input to fallback to PR head SHA for pull_request_target events. Updated Slack notification condition to skip pull_request_target events alongside existing filters.
Workflow Removal
.github/workflows/test-main-warehouse.yml		 Deleted workflow that previously ran postgres-only tests on pull requests. Functionality now consolidated into test-all-warehouses.yml with multi-warehouse support.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A workflow once lonely on postgres terrain,
Now dances with all warehouses in the chain!
Pull requests target, dbt versions lean,
One workflow to test them all—a cleaner scene! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: replacing single-warehouse (Postgres) testing with multi-warehouse testing in CI workflows.
Linked Issues check ✅ Passed All coding requirements from ELE-5218 are met: test-all-warehouses.yml now handles PRs with pull_request_target trigger, dbt 1.8.0 removed from matrix, test-main-warehouse.yml deleted, and elementary-ref updated for PR events.
Out of Scope Changes check ✅ Passed All changes are directly aligned with ELE-5218 objectives; no out-of-scope modifications detected in the workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@devin-ai-integration @haritamar
Remove workflow_call trigger (not used by any other workflow)
1472a03 
Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
@haritamar haritamar enabled auto-merge (squash) January 27, 2026 13:57
@haritamar haritamar merged commit 45831f3 into master Jan 27, 2026
6 checks passed
@haritamar haritamar deleted the devin/1769520980-cli-tests-all-warehouses branch January 27, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arbiv arbiv arbiv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arbiv @haritamar